Skip to content

intial commit for ceph-cosi-driver #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 1, 2021
Merged

intial commit for ceph-cosi-driver #1

merged 4 commits into from
Jul 1, 2021

Conversation

@thotz
Copy link
Collaborator

@thotz thotz commented Jun 4, 2021 •
edited
Loading

This is the first step towards COSI driver implementation for ceph.
Signed-off-by: Jiffin Tony Thottan [email protected]

@thotz
Copy link
Collaborator Author

thotz commented Jun 4, 2021 •
edited
Loading

Currently creation of BAR is working atm, kubernetes-retired/container-object-storage-interface-controller#55

leseb
leseb suggested changes Jun 4, 2021
View reviewed changes
Copy link
Member

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Briefly review, thanks for all the work!

@thotz thotz mentioned this pull request Jun 10, 2021
Closed
thotz added 2 commits June 10, 2021 14:56
@thotz
intial commit for ceph-cosi-driver
ab14474 
Signed-off-by: Jiffin Tony Thottan <[email protected]>
@thotz
fixing license, .gitignore file, go modules
1997f32 
addressed Sebastain's comments

Signed-off-by: Jiffin Tony Thottan <[email protected]>
@thotz thotz requested a review from leseb June 10, 2021 10:57
leseb
leseb suggested changes Jun 10, 2021
View reviewed changes
@thotz
added error messgae interface, code reading improvements
24a18fc 
Addressed Sebastain's comment on previous PR

Signed-off-by: Jiffin Tony Thottan <[email protected]>
@thotz thotz requested a review from leseb June 11, 2021 12:58
leseb
leseb suggested changes Jun 11, 2021
View reviewed changes
Copy link
Member

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few small nits

@thotz
added Makefile to build and clean.
ed3cb37 
addressed Seb's comments on my previous commit

Signed-off-by: Jiffin Tony Thottan <[email protected]>
@thotz thotz requested a review from leseb July 1, 2021 11:49
@leseb
Copy link
Member

leseb commented Jul 1, 2021

@thotz I don't see any gh action yet but I see you added a make? Is it planned in another PR?

@thotz
Copy link
Collaborator Author

thotz commented Jul 1, 2021

@thotz I don't see any gh action yet but I see you added a make? Is it planned in another PR?

I just added make file building container image, no test cases or gh actions added till now. Will add as separate PR

@leseb
Copy link
Member

leseb commented Jul 1, 2021 •
edited
Loading

@thotz I don't see any gh action yet but I see you added a make? Is it planned in another PR?

I just added make file building container image, no test cases or gh actions added till now. Will add as separate PR

Sounds good`, anything else before I merge this?

@thotz
Copy link
Collaborator Author

thotz commented Jul 1, 2021

@thotz I don't see any gh action yet but I see you added a make? Is it planned in another PR?

I just added make file building container image, no test cases or gh actions added till now. Will add as separate PR

Sounds good`, anything else before I merge this?

This can be base for the next set of work, it defines all the existing APIs provided by the COSI(still need to improve)

@leseb leseb merged commit 2e6662b into ceph:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@leseb leseb leseb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thotz @leseb