Skip to content

rbd: prevent panic when using rbdImage that is not connected #4841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2024
Merged

rbd: prevent panic when using rbdImage that is not connected #4841

merged 1 commit into from
Sep 18, 2024

Conversation

@nixpanic
Copy link
Member

@nixpanic nixpanic commented Sep 16, 2024 •
edited
Loading

When an rbdVolume or rbdSnapshot is not connected with credentials
to the Ceph cluster, operations may try to get the IOContext which then
causes a panic.

@mergify mergify bot added the component/rbd Issues related to RBD label Sep 16, 2024
iPraveenParihar
iPraveenParihar approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@iPraveenParihar iPraveenParihar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Sep 17, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Sep 17, 2024
@nixpanic
Copy link
Member Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2024

refresh

✅ Pull request refreshed

@iPraveenParihar
Copy link
Contributor

/retest ci/centos/mini-e2e/k8s-1.29

@nixpanic
Copy link
Member Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2024

refresh

✅ Pull request refreshed

@nixpanic
Copy link
Member Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Sep 17, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Sep 17, 2024
@nixpanic
Copy link
Member Author

Argh, e2e was finished already, but due to the Mergify outage it wasn't detected 😞

@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e-helm/k8s-1.30

@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e-helm/k8s-1.30

https://jenkins-ceph-csi.apps.ocp.cloud.ci.centos.org/blue/organizations/jenkins/mini-e2e-helm_k8s-1.30/detail/mini-e2e-helm_k8s-1.30/214/pipeline

[FAILED] backend images not matching kubernetes resource count,image count 1 kubernetes resource count 0

@nixpanic
Copy link
Member Author

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@nixpanic
Copy link
Member Author

Missing DCO ci-job, needs a rebase to trigger it again.

@nixpanic nixpanic added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures labels Sep 18, 2024
@nixpanic
Copy link
Member Author

Skipping some of the ci jobs as they passed already and only a doc PR is merged since.

@nixpanic
Copy link
Member Author

@Mergifyio rebase

@nixpanic
rbd: prevent panic when using rbdImage that is not connected
76c0c62 
When an `rbdVolume` or `rbdSnapshot` is not connected with credentials
to the Ceph cluster, operations may try to get the IOContext which then
causes a panic.

Signed-off-by: Niels de Vos <[email protected]>
@mergify
Copy link
Contributor

mergify bot commented Sep 18, 2024

rebase

✅ Branch has been successfully rebased

@nixpanic
Copy link
Member Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Sep 18, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 05d501a

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Sep 18, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Sep 18, 2024
@mergify mergify bot merged commit 05d501a into ceph:devel Sep 18, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

@Rakshith-R Rakshith-R Awaiting requested review from Rakshith-R

Assignees

No one assigned

Labels

ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/rbd Issues related to RBD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nixpanic @ceph-csi-bot @iPraveenParihar @Madhu-1 @Rakshith-R