Skip to content

ci: use private retest github action #4879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2024
Merged

ci: use private retest github action #4879

merged 1 commit into from
Oct 2, 2024

Conversation

@Nikhil-Ladha
Copy link
Contributor

@Nikhil-Ladha Nikhil-Ladha commented Oct 1, 2024 •
edited by nixpanic
Loading

Use private retest github action instead of pinning to a single branch/commit hash.

Closes: #4878

@Nikhil-Ladha Nikhil-Ladha mentioned this pull request Oct 1, 2024
Closed
@mergify mergify bot added the component/testing Additional test cases or CI work label Oct 1, 2024
nixpanic
nixpanic approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good, thanks!

@nixpanic nixpanic added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures labels Oct 1, 2024
@nixpanic nixpanic requested a review from a team October 1, 2024 09:05
Madhu-1
Madhu-1 reviewed Oct 1, 2024
View reviewed changes
.github/workflows/retest.yaml Outdated
# yamllint disable-line rule:line-length
- uses: ceph/ceph-csi/actions/retest@28dc64dcae3cec8d11d84bdf525bda0ef757c688 # devel
- name: Checkout the ceph-csi respository
uses: actions/checkout@v4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not be using v4 (it should be a hash) here isn't it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, use this:

uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right.
Updated it now :)

nixpanic
nixpanic requested changes Oct 1, 2024
View reviewed changes
.github/workflows/retest.yaml Outdated
# yamllint disable-line rule:line-length
- uses: ceph/ceph-csi/actions/retest@28dc64dcae3cec8d11d84bdf525bda0ef757c688 # devel
- name: Checkout the ceph-csi respository
uses: actions/checkout@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, use this:

uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0

@Madhu-1 Madhu-1 requested a review from nixpanic October 1, 2024 09:16
@nixpanic
Copy link
Member

nixpanic commented Oct 2, 2024

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 44368bf

@Nikhil-Ladha
ci: use private retest github action
bc97de8 
use private retest github action instead of pinning
to a single branch/commit hash.

Signed-off-by: Nikhil-Ladha <[email protected]>
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Oct 2, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Oct 2, 2024
@mergify mergify bot merged commit 44368bf into ceph:devel Oct 2, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nixpanic nixpanic nixpanic approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

Assignees

No one assigned

Labels

ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Nikhil-Ladha @nixpanic @ceph-csi-bot @Madhu-1