helm: Support setting annotations for nodePlugin and provisioner #4908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
the
component/deployment
nixpanic
approved these changes
Oct 15, 2024
nixpanic
added
the
ci/skip/multi-arch-build
iPraveenParihar
approved these changes
Oct 15, 2024
iPraveenParihar
approved these changes
Oct 15, 2024
|
@Mergifyio rebase |
Adding annotation support to both the CephFS and RBD charts. Support setting the DaemonSet and Pod level annotations for the nodeplugin. Support setting the Deployment and Pod level annotations for the provisioner. Signed-off-by: Mike Vollman <[email protected]>
✅ Branch has been successfully rebased |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at d1c28fa |
|
Thanks for the PR @mvollman! |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add annotation support for both the RBD and CephFS Helm charts. Allow setting annotations at the nodePlugin DaemonSet level and Pod level and at the provisioner Deployment and Pod level. This change will not make any changes to existing deployments by default. Changes will only be made if the
nodePlugin.podAnnotations,nodePlugin.annotations,provisioner.annotations, orprovisioner.podAnnotationsvalues are set. While testing I discovered that there was an existing pre-commit error with the check-yaml hook. It fails on the devel branch when testing the helm templates, presumably due to them being templates and not pure yaml files. I added an exclusion for these templates to get the hooks to pass.