RBD: Flatten group snapshot #4973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
Rakshith-R
added
WIP
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
5 additional group snapshots are created and deleted successfully. |
Rakshith-R
force-pushed
the
flatten-group-snapshot
branch
5 times, most recently
from
d22ce45 to
234ae0c
Compare
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.31 |
|
E2E changes in this pr adds creation & deletion of additional volumegroupsnapshots.
|
Rakshith-R
force-pushed
the
flatten-group-snapshot
branch
3 times, most recently
from
4c35c58 to
8882254
Compare
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
Rakshith-R
force-pushed
the
flatten-group-snapshot
branch
from
8882254 to
43cf95f
Compare
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
Rakshith-R
force-pushed
the
flatten-group-snapshot
branch
from
43cf95f to
5edecc9
Compare
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
1 similar comment
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
Rakshith-R
force-pushed
the
flatten-group-snapshot
branch
from
b41a344 to
94b9f0b
Compare
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
Rakshith-R
force-pushed
the
flatten-group-snapshot
branch
from
94b9f0b to
771763a
Compare
Rakshith-R
changed the title
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
Rakshith-R
removed
WIP
Currently, CephCSI only uses listSnaps to determine number of snapshots on a RBD image and uses snapshot names as child image names to flatten them. But child images may have different name(in case of group snapshot) or they maybe in trash (deleted k8s VolSnapshot with alive restored PVC). The above problems are avoid by making use of both snap and child image lists. Signed-off-by: Rakshith R <[email protected]>
Signed-off-by: Rakshith R <[email protected]>
Rakshith-R
force-pushed
the
flatten-group-snapshot
branch
from
3562eea to
2597e45
Compare
Resolved dependencies, PTAL |
iPraveenParihar
approved these changes
Dec 17, 2024
Madhu-1
approved these changes
Dec 17, 2024
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
|
/retest ci/centos/mini-e2e/k8s-1.29 |
Madhu-1
added
the
backport-to-release-v3.13
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 50b2a05 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Related issues
related-to: #5000
Fixes: #issue_number
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)