Skip to content

build: update rook version to v1.16.4 #5181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

build: update rook version to v1.16.4 #5181

merged 1 commit into from
Mar 3, 2025

Conversation

@iPraveenParihar
Copy link
Contributor

@iPraveenParihar iPraveenParihar commented Feb 27, 2025 •
edited
Loading

Describe what this PR does

Update ROOK_VERSION to latest available v1.16.4 to use in E2E tests

Depends-On: #5182

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@mergify mergify bot added the component/build Issues and PRs related to compiling Ceph-CSI label Feb 27, 2025
@iPraveenParihar iPraveenParihar marked this pull request as ready for review February 27, 2025 08:56
Madhu-1
Madhu-1 reviewed Feb 27, 2025
View reviewed changes
build.env

# Rook options
ROOK_VERSION=v1.14.9
ROOK_VERSION=v1.16.4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iPraveenParihar https://github.com/ceph/ceph-csi/blob/ci/centos/mirror/images.txt#L10 This also need to be updated first to avoid pull limit issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its only required once to mirror the image repository? and not for each tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its only required once to mirror the image repository? and not for each tag.

Yea, I was under wrong assumption.

@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e/k8s-1.31

@nixpanic nixpanic requested a review from a team February 27, 2025 13:08
@Rakshith-R
Copy link
Contributor

/test ci/centos/mini-e2e/k8s-1.31

@iPraveenParihar
Copy link
Contributor Author 

Trying to pull registry-ceph-csi.apps.ocp.cloud.ci.centos.org/rook/ceph:v1.16.4...

Error: initializing source docker://registry-ceph-csi.apps.ocp.cloud.ci.centos.org/rook/ceph:v1.16.4: reading manifest v1.16.4 in registry-ceph-csi.apps.ocp.cloud.ci.centos.org/rook/ceph: manifest unknown

script returned exit code 125

mirror sync will happen tomorrow probably? @nixpanic

@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e/k8s-1.31

@Rakshith-R
Copy link
Contributor

@Mergifyio rebase

@Rakshith-R Rakshith-R closed this Mar 3, 2025
@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2025

rebase

☑️ Nothing to do

  • -closed [📌 rebase requirement]
  • -conflict [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]
  • any of:
    • #commits-behind > 0 [📌 rebase requirement]
    • #commits > 1 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]

@Rakshith-R Rakshith-R reopened this Mar 3, 2025
@Rakshith-R
Copy link
Contributor

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2025 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@iPraveenParihar iPraveenParihar force-pushed the build/update-rook-version branch from 722355f to dcb80a4 Compare March 3, 2025 06:28
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Mar 3, 2025
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Mar 3, 2025
@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@Rakshith-R
Copy link
Contributor

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

both failed due to

hudson.plugins.git.GitException: Command "git fetch --tags --force --progress -- https://github.com/ceph/ceph-csi +refs/heads/*:refs/remotes/origin/*" returned status code 128:

stdout: 

stderr: remote: Enumerating objects: 128479, done.        

Receiving objects:   0% (1/128479)
Receiving objects:   0% (37/128479), 16.01 KiB | 12.00 KiB/s
Receiving objects:   0% (51/128479), 20.01 KiB | 9.00 KiB/s 
Receiving objects:   0% (66/128479), 20.01 KiB | 9.00 KiB/s
Receiving objects:   0% (79/128479), 28.01 KiB | 7.00 KiB/s
Receiving objects:   0% (91/128479), 32.01 KiB | 6.00 KiB/s
Receiving objects:   0% (105/128479), 36.01 KiB | 5.00 KiB/s
Receiving objects:   0% (119/128479), 40.01 KiB | 5.00 KiB/s
Receiving objects:   0% (137/128479), 44.01 KiB | 5.00 KiB/s
Receiving objects:   0% (159/128479), 48.01 KiB | 5.00 KiB/s
Receiving objects:   0% (185/128479), 56.01 KiB | 5.00 KiB/s
Receiving objects:   1% (1285/128479), 64.01 KiB | 5.00 KiB/s
Receiving objects:   2% (2570/128479), 64.01 KiB | 5.00 KiB/s
error: RPC failed; curl 18 transfer closed with outstanding read data remaining

error: 5091 bytes of body are still expected

fetch-pack: unexpected disconnect while reading sideband packet

@Rakshith-R
Copy link
Contributor

/retest ci/centos/mini-e2e-helm/k8s-1.31

@Rakshith-R
Copy link
Contributor

/retest ci/centos/mini-e2e/k8s-1.31

@iPraveenParihar
Copy link
Contributor Author

/retest ci/centos/k8s-e2e-external-storage/1.30

@iPraveenParihar
Copy link
Contributor Author

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot merged commit 106e322 into ceph:devel Mar 3, 2025
37 checks passed
@iPraveenParihar iPraveenParihar mentioned this pull request Mar 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Madhu-1 Madhu-1 Madhu-1 left review comments

@nixpanic nixpanic nixpanic approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

Assignees

No one assigned

Labels

component/build Issues and PRs related to compiling Ceph-CSI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iPraveenParihar @Rakshith-R @ceph-csi-bot @nixpanic @Madhu-1