ci: update rule for ci/skip/e2e #5208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpanic
reviewed
Mar 11, 2025
ShravaniVangur
force-pushed
the
skipe2eLabel
branch
from
d2ccd2d to
0f1cbfc
Compare
nixpanic
added
ci/skip/e2e
Rakshith-R
reviewed
Mar 11, 2025
ShravaniVangur
force-pushed
the
skipe2eLabel
branch
from
0f1cbfc to
5a81668
Compare
Rakshith-R
reviewed
Mar 11, 2025
Comment on lines
+150
to
+146
| - "status-success=ci/centos/k8s-e2e-external-storage/1.30" | ||
| - "status-success=ci/centos/k8s-e2e-external-storage/1.31" | ||
| - "status-success=ci/centos/k8s-e2e-external-storage/1.32" | ||
| - "status-success=ci/centos/mini-e2e-helm/k8s-1.30" | ||
| - "status-success=ci/centos/mini-e2e-helm/k8s-1.31" | ||
| - "status-success=ci/centos/mini-e2e-helm/k8s-1.32" | ||
| - "status-success=ci/centos/mini-e2e/k8s-1.30" | ||
| - "status-success=ci/centos/mini-e2e/k8s-1.31" | ||
| - "status-success=ci/centos/mini-e2e/k8s-1.32" | ||
| - "status-success=ci/centos/upgrade-tests-cephfs" | ||
| - "status-success=ci/centos/upgrade-tests-rbd" |
There was a problem hiding this comment.
Suggested change
| - "status-success=ci/centos/k8s-e2e-external-storage/1.30" | |
| - "status-success=ci/centos/k8s-e2e-external-storage/1.31" | |
| - "status-success=ci/centos/k8s-e2e-external-storage/1.32" | |
| - "status-success=ci/centos/mini-e2e-helm/k8s-1.30" | |
| - "status-success=ci/centos/mini-e2e-helm/k8s-1.31" | |
| - "status-success=ci/centos/mini-e2e-helm/k8s-1.32" | |
| - "status-success=ci/centos/mini-e2e/k8s-1.30" | |
| - "status-success=ci/centos/mini-e2e/k8s-1.31" | |
| - "status-success=ci/centos/mini-e2e/k8s-1.32" | |
| - "status-success=ci/centos/upgrade-tests-cephfs" | |
| - "status-success=ci/centos/upgrade-tests-rbd" | |
| -or: | |
| - label=ci/skip/e2e | |
| - and: | |
| - "status-success=ci/centos/k8s-e2e-external-storage/1.30" | |
| - "status-success=ci/centos/k8s-e2e-external-storage/1.31" | |
| - "status-success=ci/centos/k8s-e2e-external-storage/1.32" | |
| - "status-success=ci/centos/mini-e2e-helm/k8s-1.30" | |
| - "status-success=ci/centos/mini-e2e-helm/k8s-1.31" | |
| - "status-success=ci/centos/mini-e2e-helm/k8s-1.32" | |
| - "status-success=ci/centos/mini-e2e/k8s-1.30" | |
| - "status-success=ci/centos/mini-e2e/k8s-1.31" | |
| - "status-success=ci/centos/mini-e2e/k8s-1.32" | |
| - "status-success=ci/centos/upgrade-tests-cephfs" | |
| - "status-success=ci/centos/upgrade-tests-rbd" |
I think something like this is better ?
There was a problem hiding this comment.
Can you adopt this same format at all places where centos-ci status is being checked ?
release branches are being left out currently in this pr.
There was a problem hiding this comment.
Adapted this format for pull_request_rules and queue_rules.
ShravaniVangur
force-pushed
the
skipe2eLabel
branch
2 times, most recently
from
82259c5 to
2a616e4
Compare
ShravaniVangur
force-pushed
the
skipe2eLabel
branch
from
2a616e4 to
e6ef695
Compare
nixpanic
approved these changes
Mar 12, 2025
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 3ea4199 |
updates mergify rules to handle ci/skip/e2e label Signed-off-by: ShravaniVangur <[email protected]>
ShravaniVangur
force-pushed
the
skipe2eLabel
branch
from
e6ef695 to
ce94ee3
Compare
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Currently, when a queue operation is triggered with mergifyio, the
ok-to-testlabel is being added even when theci/skip/e2elabel is present. This PR updates the logic to ensure that theci/skip/e2elabel is handled correctly.In this PR:
For
pull_request_rules: Before adding theok-to-testlabel, the presence of theci/skip/e2elabel is checked. If it is present, theok-to-test labelis not added.For
queue_rules: If theci/skip/e2elabel is present and the basic tests have passed, the merge will be triggered.Fixes: #5156