Skip to content

rbd: do not start the healer for NBD on non-Kubernetes platforms #5247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

rbd: do not start the healer for NBD on non-Kubernetes platforms #5247

merged 1 commit into from
Apr 2, 2025

Conversation

@nixpanic
Copy link
Member

@nixpanic nixpanic commented Mar 31, 2025 •
edited
Loading

When running on Docker Swarm, the RBD-healer fails with an error like:

healer had failures, err failed to get cluster config: unable to load
in-cluster configuration, KUBERNETES_SERVICE_HOST and
KUBERNETES_SERVICE_PORT must be defined

Before starting the healer, check if KUBERNETES_SERVICE_HOST is set in
the environment variables so that non-Kubernetes platforms do not get
confusing warnings.

Updates: #3769

@mergify mergify bot added the component/rbd Issues related to RBD label Mar 31, 2025
@nixpanic nixpanic requested a review from a team April 1, 2025 07:00
Rakshith-R
Rakshith-R requested changes Apr 1, 2025
View reviewed changes
@nixpanic nixpanic force-pushed the cleanup/rbd-healer/no-k8s branch from f8f1316 to 3402d2f Compare April 1, 2025 09:02
Rakshith-R
Rakshith-R approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Rakshith-R Rakshith-R requested a review from a team April 1, 2025 09:04
@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2025

@Mergifyio rebase

@nixpanic
rbd: do not start the healer for NBD on non-Kubernetes platforms
f2792c7 
When running on Docker Swarm, the RBD-healer fails with an error like:

> healer had failures, err failed to get cluster config: unable to load
> in-cluster configuration, KUBERNETES_SERVICE_HOST and
> KUBERNETES_SERVICE_PORT must be defined

Before starting the healer, check if we're running on Kubernetes, so
that non-Kubernetes platforms do not get confusing warnings.

Updates: ceph#3769
Signed-off-by: Niels de Vos <[email protected]>
@mergify
Copy link
Contributor

mergify bot commented Apr 2, 2025

rebase

✅ Branch has been successfully rebased

@nixpanic nixpanic force-pushed the cleanup/rbd-healer/no-k8s branch from 3402d2f to f2792c7 Compare April 2, 2025 09:56
@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2025

/test ci/centos/mini-e2e-helm/k8s-1.32

@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2025

/test ci/centos/mini-e2e-helm/k8s-1.31

@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2025

/test ci/centos/mini-e2e-helm/k8s-1.30

@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2025

/test ci/centos/mini-e2e/k8s-1.32

@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2025

/test ci/centos/mini-e2e/k8s-1.31

@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2025

/test ci/centos/mini-e2e/k8s-1.30

@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2025

/test ci/centos/k8s-e2e-external-storage/1.32

@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2025

/test ci/centos/k8s-e2e-external-storage/1.31

@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2025

/test ci/centos/k8s-e2e-external-storage/1.30

@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2025

/test ci/centos/upgrade-tests

@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2025

/retest ci/centos/mini-e2e/k8s-1.31

@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2025

/retest ci/centos/mini-e2e/k8s-1.31

not sure why this failed, glancing shows something unexpected:

  I0402 11:16:15.643446 81445 pv.go:801] PersistentVolumeClaim rbd-pvc found and phase=Bound (1.35059ms)
  I0402 11:16:15.643477 81445 pv.go:763] Waiting up to 10m0s for PersistentVolume pvc-754cbdaa-430e-43fa-b4ea-268d5f5d4847 to have phase Bound
  I0402 11:16:15.645064 81445 pv.go:771] PersistentVolume pvc-754cbdaa-430e-43fa-b4ea-268d5f5d4847 found and phase=Bound (1.57318ms)
  W0402 11:16:15.650629   81445 warnings.go:70] would violate PodSecurity "restricted:latest": allowPrivilegeEscalation != false (container "web-server" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "web-server" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (pod or container "web-server" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container "web-server" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
  I0402 11:16:15.650690 81445 pod.go:366] Waiting up to csi-rbd-demo-pod to be in Running state
  �[38;5;9m[FAILED]�[0m in [It] - /go/src/github.com/ceph/ceph-csi/e2e/rbd.go:5201 �[38;5;243m@ 04/02/25 11:26:15.651�[0m

logs

@mergify mergify bot merged commit 437d90c into ceph:devel Apr 2, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@black-dragon74 black-dragon74 black-dragon74 approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

Assignees

No one assigned

Labels

component/rbd Issues related to RBD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nixpanic @black-dragon74 @Rakshith-R