helm: mark userID and userKey required in secret #5288
Conversation
mergify
bot
added
the
component/deployment
black-dragon74
force-pushed
the
helm-compat-user-creds
branch
from
cf3c7ec to
0da5296
Compare
PendingReleaseNotes.md
Outdated
|
|
||
| ## Breaking Changes | ||
|
|
||
| - Support for `secret.adminID` and `secret.adminKey` has been deprecated and removed. |
There was a problem hiding this comment.
I think it is only removed from the Helm charts? It is not a breaking change if users did not use Helm to deploy? That could be explained a little better.
black-dragon74
force-pushed
the
helm-compat-user-creds
branch
from
0da5296 to
c992645
Compare
| userID: {{ required "A valid userID must be specified in secret" .Values.secret.userID }} | ||
| userKey: {{ required "A valid userKey must be specified in secret" .Values.secret.userKey }} |
There was a problem hiding this comment.
should we add adminID and adminKey back in this release and deprecate it and Remove it in next major release?
thoughts?
There was a problem hiding this comment.
That would make sense actually. This got overlooked in the previous release. Breaking changes should not be a part of minor/patch versions.
|
Does this report the new required message, even if |
Yes. |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 20b9ecc |
This patch marks `userID` and `userKey` required in helm values. A release note has been added for the same as well. Signed-off-by: Niraj Yadav <[email protected]>
mergify
bot
force-pushed
the
helm-compat-user-creds
branch
from
c992645 to
209c624
Compare
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
|
/test ci/centos/mini-e2e/k8s-1.32 |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
4 participants
Describe what this PR does
This patch marks
userIDanduserKeyrequired in helm values.A release note has been added for the same as well.
Ref: #5282