Skip to content

Conversation

@flx5
Copy link
Contributor

@flx5 flx5 commented Apr 28, 2025

When cephfs is used with encryption an exclusive lock is acquired. This needs the execute permission on the metadata pool.

Fixes #4728

Future concerns

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer
    guide
    .
  • Reviewed the developer guide on Submitting a Pull
    Request
  • Pending release
    notes

    updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@mergify mergify bot added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation labels Apr 28, 2025
When cephfs is used with encryption an exclusive lock is acquired. This
needs the execute permission on the metadata pool.

Fixes: ceph#4728
Signed-off-by: Felix Prasse <[email protected]>
```
mgr "allow rw"
osd "allow rw tag cephfs metadata=cephfs, allow rw tag cephfs data=cephfs"
osd "allow rwx tag cephfs metadata=cephfs, allow rw tag cephfs data=cephfs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If am correct, the allow x permission is specifically needed when CephFS encryption is in use. If encryption is not configured, this permission can be omitted from the OSD capabilities. Can we add this as NOTE section?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. Currently it is only required when CephFS encryption is used. However, this is needed for using RADOS locks, which might get used in other places too. A note about it might be useful, but it can get outdated easily too. Once deployed, users will likely not change the capabilities later on, adding an encrypted CephFS storage class after a while is surely more common.

I am fine with the current enhancement, it will prevent others from hitting problems with this.

@nixpanic nixpanic force-pushed the feature/update-documentation-for-lock branch from ccdb9bd to 629c997 Compare April 29, 2025 06:56
Copy link
Contributor

@iPraveenParihar iPraveenParihar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit 031e900 into ceph:devel Apr 29, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the capabilities needed for client.csi-cephfs-node in case of encryption

3 participants