Skip to content

enable setmetadata flag by default #5333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

enable setmetadata flag by default #5333

merged 1 commit into from
May 29, 2025

Conversation

@yati1998
Copy link
Contributor

@yati1998 yati1998 commented May 26, 2025 •
edited
Loading

this enables setmetadata flag by default.

Fixes: #5328

@yati1998 yati1998 force-pushed the metadata branch 2 times, most recently from fe96e46 to bd4ea6b Compare May 26, 2025 08:52
@yati1998 yati1998 changed the title cmd: enable setmetadata by default enable setmetadata by default May 26, 2025
@yati1998 yati1998 changed the title enable setmetadata by default enable setmetadata flag by default May 26, 2025
Madhu-1
Madhu-1 reviewed May 26, 2025
View reviewed changes
@yati1998 yati1998 requested review from a team and Madhu-1 May 27, 2025 02:51
Nikhil-Ladha
Nikhil-Ladha reviewed May 27, 2025
View reviewed changes
Copy link
Contributor

@Nikhil-Ladha Nikhil-Ladha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't both cephfs, rbd support this flag? If so, we should update the docs for cephfs as well.
Also, please link the already open issue #5328 in the PR description.

@yati1998
Copy link
Contributor Author

yati1998 commented May 27, 2025 •
edited
Loading

Doesn't both cephfs, rbd support this flag? If so, we should update the docs for cephfs as well.

yes, done

Also, please link the already open issue #5328 in the PR description.

it is already linked to the issue

Madhu-1
Madhu-1 reviewed May 27, 2025
View reviewed changes
Madhu-1
Madhu-1 reviewed May 27, 2025
View reviewed changes
@Nikhil-Ladha
Copy link
Contributor

it is already linked to the issue

I don't see the issue link in the PR description.
Adding the issue link in the PR description as Fixes: #issue-number closes the issues automatically when the PR is merged.

@yati1998
Copy link
Contributor Author

it is already linked to the issue

I don't see the issue link in the PR description. Adding the issue link in the PR description as Fixes: #issue-number closes the issues automatically when the PR is merged.

it is added to commit message, will update in description as well

@yati1998 yati1998 force-pushed the metadata branch 2 times, most recently from 1d6405d to 6ac0daa Compare May 27, 2025 11:09
Madhu-1
Madhu-1 reviewed May 27, 2025
View reviewed changes
Madhu-1
Madhu-1 reviewed May 27, 2025
View reviewed changes
@yati1998 yati1998 requested a review from Madhu-1 May 28, 2025 03:33
@yati1998
Copy link
Contributor Author

/retest

Madhu-1
Madhu-1 requested changes May 28, 2025
View reviewed changes
@yati1998 yati1998 requested a review from Madhu-1 May 28, 2025 08:25
@mergify mergify bot dismissed iPraveenParihar’s stale review May 28, 2025 08:25

Pull request has been modified.

@Madhu-1 Madhu-1 requested a review from iPraveenParihar May 28, 2025 13:35
@Rakshith-R
Copy link
Contributor

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented May 29, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at a007447

@yati1998 @mergify
rbd: enable setmetadata by default
80371a6 
this enables setmetadata flag by default.

fixes: ceph#5328

Signed-off-by: yati1998 <[email protected]>
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label May 29, 2025
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label May 29, 2025
@mergify mergify bot merged commit a007447 into ceph:devel May 29, 2025
36 of 37 checks passed
@mergify
Copy link
Contributor

mergify bot commented May 29, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

@Nikhil-Ladha Nikhil-Ladha Awaiting requested review from Nikhil-Ladha

@nixpanic nixpanic Awaiting requested review from nixpanic

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

set enable-metadata flag to true by default

7 participants

@yati1998 @Nikhil-Ladha @Rakshith-R @ceph-csi-bot @nixpanic @Madhu-1 @iPraveenParihar