Skip to content

csi: validate incoming VolumeGroupSnapshot requests #5353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2025
Merged

csi: validate incoming VolumeGroupSnapshot requests #5353

merged 2 commits into from
Jun 5, 2025

Conversation

@nixpanic
Copy link
Member

@nixpanic nixpanic commented Jun 5, 2025 •
edited
Loading

Add missing validation for VolumeGroupSnapshot requests.

@nixpanic nixpanic requested a review from a team June 5, 2025 11:48
@nixpanic nixpanic force-pushed the rbd/groupcontroller/validation branch 2 times, most recently from 224398a to 1fd695e Compare June 5, 2025 12:15
@nixpanic nixpanic added the component/rbd Issues related to RBD label Jun 5, 2025
Nikhil-Ladha
Nikhil-Ladha approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@Nikhil-Ladha Nikhil-Ladha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if "rbd" would have been a more appropriate commit title type for this change 🤔

@nixpanic
Copy link
Member Author

nixpanic commented Jun 5, 2025

Wondering if "rbd" would have been a more appropriate commit title type for this change 🤔

It's actually both. This validation isn't really rbd specific, only that it is in the RBD group-controller. Because it is more of a CSI-verification, I through csi as component would be better.

@nixpanic
Copy link
Member Author

nixpanic commented Jun 5, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at e2be707

nixpanic added 2 commits June 5, 2025 12:41
@nixpanic @mergify
csi: validate incoming VolumeGroupSnapshot requests
cc96c92 
Add missing validation for VolumeGroupSnapshot requests.

Signed-off-by: Niels de Vos <[email protected]>
@nixpanic @mergify
ci: add "csi" component for commitlint
b9ec9cb 
Signed-off-by: Niels de Vos <[email protected]>
@mergify mergify bot force-pushed the rbd/groupcontroller/validation branch from 1fd695e to b9ec9cb Compare June 5, 2025 12:41
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Jun 5, 2025
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jun 5, 2025
@mergify mergify bot merged commit e2be707 into ceph:devel Jun 5, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nikhil-Ladha Nikhil-Ladha Nikhil-Ladha approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

Assignees

No one assigned

Labels

component/rbd Issues related to RBD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nixpanic @ceph-csi-bot @Nikhil-Ladha @Rakshith-R