doc: add v3 symlink to get current versions in pkg.go.dev (backport #5364)
#5379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
ok-to-test
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.32 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
Madhu-1
approved these changes
Jun 23, 2025
|
@Mergifyio rebase |
https://pkg.go.dev/github.com/ceph/ceph-csi does not list the current v3.14.0 release. It seems to come from the fact that a v3 release of a Go module expects a v3/go.mod file in the repository. Instead of moving all files from the root of the repository to a new `v3` directory, make a symlink so that https://github.com/ceph/ceph-csi/v3/go.mod resolves correctly (eventhough the go.mod does not reference /v3). Signed-off-by: Niels de Vos <[email protected]> (cherry picked from commit 0778a37)
✅ Branch has been successfully rebased |
Madhu-1
force-pushed
the
mergify/bp/release-v3.14/pr-5364
branch
from
76eb15e to
7a500da
Compare
Madhu-1
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pkg.go.dev/github.com/ceph/ceph-csi does not list the current
v3.14.0 release. It seems to come from the fact that a v3 release of a
Go module expects a v3/go.mod file in the repository. Instead of moving
all files from the root of the repository to a new
v3directory, makea symlink so that https://github.com/ceph/ceph-csi/v3/go.mod resolves
correctly (eventhough the go.mod does not reference /v3).
Steps to add a package (also has a suggestion for a version):
The Go proxy protocol is used to track available versions, and this would be a request for the v3.14.0 version:
https://proxy.golang.org/github.com/ceph/ceph-csi/v3/@v/v3.14.0.infoThat results in an error like
Adding the
v3symlink to the root of the directory might be sufficient to get the documentation generated.This is an automatic backport of pull request #5364 done by Mergify.