flattenClonedRbdImages may require namespace (backport #5392) #5396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flattenClonedRbdImages() requires namespace if it not the default one. Signed-off-by: Olivier Doucet <[email protected]> (cherry picked from commit b0eb428)
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.32 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e/k8s-1.30 |
Rakshith-R
approved these changes
Jun 25, 2025
nixpanic
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
PrepareVolumeForSnapshot()orflattenParentImage()requires rbd image flattening, that is performed in functionflattenClonedRbdImages(). This function is lacking namespace support. This was undetected before because ceph local installs, used as tests, provides a default namespace and it's not common behaviour to create new ones.The underlying bug is very critical : snapshots are performed but flattening are never performed, leading to accumulation of data.
Is there anything that requires special attention
Do you have any questions? no
Is the change backward compatible? yes
Are there concerns around backward compatibility? this code was tested with non-default namespaces but should be tested proactively in all situations.
Future concerns
Checklist:
guidelines in the developer guide.
This is my first PR on this project, let me know if I missed something.
This is an automatic backport of pull request #5392 done by Mergify.