Skip to content

Run cryptsetup with "-d -" instead of "-d /dev/stdin" (backport #5307) #5407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

Run cryptsetup with "-d -" instead of "-d /dev/stdin" (backport #5307) #5407

merged 1 commit into from
Jul 4, 2025

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jul 2, 2025

Suggested fix for #5306

Fixes: #5306

This is an automatic backport of pull request #5307 done by [Mergify](https://mergify.com).

@bartlaarhoven @mergify
util: run cryptsetup with "-d -" instead of "-d /dev/stdin"
0e04d5d 
Make sure that cryptsetup runs with the correct parameters to fix issues
in some environments.

Signed-off-by: Bart Laarhoven <[email protected]>
(cherry picked from commit fdb4002)
@mergify mergify bot mentioned this pull request Jul 2, 2025
Merged
@Madhu-1 Madhu-1 requested a review from nixpanic July 2, 2025 07:36
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jul 2, 2025

@Mergifyio queue

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Jul 2, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Jul 2, 2025 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The following conditions don't match anymore:

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jul 2, 2025
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Jul 2, 2025
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jul 2, 2025
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jul 2, 2025

Looks like some problem with CI automation, Its keep on adding/removing the label

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jul 2, 2025

Looks like some problem with CI automation, Its keep on adding/removing the label

It looks like sideeffect of a bug in the mergify config file, as the centos CI is not shown or published here, the mergify is adding the label again

Rakshith-R
Rakshith-R previously requested changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci needs to be checked ?

@mergify
Copy link
Contributor Author

mergify bot commented Jul 2, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #5407 has been dequeued. The pull request rule doesn't match anymore.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@nixpanic nixpanic marked this pull request as draft July 2, 2025 07:49
@nixpanic
Copy link
Member

nixpanic commented Jul 2, 2025

Converted to Draft, maybe that prevents further issues for now?

@nixpanic
Copy link
Member

nixpanic commented Jul 2, 2025

CI is unavailable at the time, see https://lists.centos.org/hyperkitty/list/[email protected]/thread/5XIYV5SJO7FSK22XZUXIDGT7WWG73IWC/

@nixpanic
Copy link
Member

nixpanic commented Jul 4, 2025

/test ci/centos/mini-e2e/k8s-1.30

1 similar comment
@nixpanic
Copy link
Member

nixpanic commented Jul 4, 2025

/test ci/centos/mini-e2e/k8s-1.30

@nixpanic
Copy link
Member

nixpanic commented Jul 4, 2025

@Mergifyio requeue

@mergify
Copy link
Contributor Author

mergify bot commented Jul 4, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@nixpanic nixpanic marked this pull request as ready for review July 4, 2025 13:19
@nixpanic nixpanic dismissed Rakshith-R’s stale review July 4, 2025 13:20

Fixed the CI issue, I hope.

@mergify mergify bot merged commit 3432d8a into release-v3.14 Jul 4, 2025
107 checks passed
@mergify mergify bot deleted the mergify/bp/release-v3.14/pr-5307 branch July 4, 2025 13:21
@bartlaarhoven bartlaarhoven mentioned this pull request Jul 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nixpanic nixpanic nixpanic approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@Rakshith-R Rakshith-R Rakshith-R left review comments

Assignees

No one assigned

Labels

ci/skip/e2e skip running e2e CI jobs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Madhu-1 @ceph-csi-bot @nixpanic @Rakshith-R @bartlaarhoven