-
Couldn't load subscription status.
- Fork 580
fix: Tracevol now correctly parses hexadecimal pool id #5451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jggc can you please fix commitlint issue |
Pool id is a hex string, the previous `int(pool_id)` call fails when there is more than 10 pools in the cluster. Signed-off-by: Jean-Gab <[email protected]>
|
@jggc, thanks for the PR! I've taken the liberty to correct the commit message. This should be ready for merging now. |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 54a1c1f |
Sorry about the delay, I almost never check my github notifs 😅 Thanks for the fix and merge! |
Pool id is a hex string, the previous
int(pool_id)call fails when there is more than 10 pools in the cluster.Describe what this PR does
Fix the parsing of pool id in tracevol.py utility
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)