Skip to content

Conversation

@jggc
Copy link
Contributor

@jggc jggc commented Jul 25, 2025

Pool id is a hex string, the previous int(pool_id) call fails when there is more than 10 pools in the cluster.

Describe what this PR does

Fix the parsing of pool id in tracevol.py utility

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer
    guide
    .
  • Reviewed the developer guide on Submitting a Pull
    Request
  • Pending release
    notes

    updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@mergify mergify bot added the bug Something isn't working label Jul 25, 2025
@Madhu-1 Madhu-1 added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures labels Jul 28, 2025
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jul 28, 2025

commitlint --verbose --from origin/devel
⧗   input: fix: Tracevol now correctly parses hexadecimal pool id
Pool id is a hex string, the previous `int(pool_id)` call fails when there is more than 10 pools in the cluster.
Signed-off-by: Jean-Gab <[email protected]>
✖   body's lines must not be longer than 80 characters [body-max-line-length]
✖   type must be one of [build, cephfs, ci, csi, csiaddons, cleanup, deploy, doc, e2e, helm, journal, rbd, rebase, revert, util, nfs] [type-enum]
✖   found 2 problems, 0 warnings

@jggc can you please fix commitlint issue

Pool id is a hex string, the previous `int(pool_id)` call fails when
there is more than 10 pools in the cluster.

Signed-off-by: Jean-Gab <[email protected]>
@nixpanic
Copy link
Member

nixpanic commented Aug 7, 2025

@jggc, thanks for the PR!

I've taken the liberty to correct the commit message. This should be ready for merging now.

@nixpanic nixpanic requested review from a team and Madhu-1 August 7, 2025 06:51
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 7, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Aug 7, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 54a1c1f

@mergify mergify bot merged commit 54a1c1f into ceph:devel Aug 7, 2025
15 checks passed
mergify bot added a commit that referenced this pull request Aug 7, 2025
@jggc
Copy link
Contributor Author

jggc commented Sep 10, 2025

commitlint --verbose --from origin/devel
⧗   input: fix: Tracevol now correctly parses hexadecimal pool id
Pool id is a hex string, the previous `int(pool_id)` call fails when there is more than 10 pools in the cluster.
Signed-off-by: Jean-Gab <[email protected]>
✖   body's lines must not be longer than 80 characters [body-max-line-length]
✖   type must be one of [build, cephfs, ci, csi, csiaddons, cleanup, deploy, doc, e2e, helm, journal, rbd, rebase, revert, util, nfs] [type-enum]
✖   found 2 problems, 0 warnings

@jggc can you please fix commitlint issue

Sorry about the delay, I almost never check my github notifs 😅

Thanks for the fix and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants