Skip to content

Conversation

@YiteGu
Copy link
Member

@YiteGu YiteGu commented Aug 12, 2025

Describe what this PR does

we should change this to small to align this with other parameters.


Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@mergify mergify bot added the component/rbd Issues related to RBD label Aug 12, 2025
@YiteGu YiteGu force-pushed the adjust-qos-param-format branch from 0ffcf8d to c2e07aa Compare August 12, 2025 03:17
@iPraveenParihar
Copy link
Contributor

@YiteGu, Can you please add a message in PR description why is this change needed and same in commit message?

@YiteGu
Copy link
Member Author

YiteGu commented Aug 12, 2025

we should change this to small to align this with other parameters.

updated. the purpose is very simple. change QOS params to small to align this with other parameters.

@nixpanic
Copy link
Member

This isn't backwards compatible, is that a problem? Existing StorageClasses with the old parameters won't keep functioning when Ceph-CSI is updated to use the new parameters.

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 12, 2025

This isn't backwards compatible, is that a problem? Existing StorageClasses with the old parameters won't keep functioning when Ceph-CSI is updated to use the new parameters.

This isn't backwards compatible, is that a problem? Existing StorageClasses with the old parameters won't keep functioning when Ceph-CSI is updated to use the new parameters.

@nixpanic ceph-csi never advertized nbd as supported mounter, its currently kept as alpha feature only https://github.com/ceph/ceph-csi/blob/devel/docs/design/proposals/rbd-nbd.md#status, This change is required to keep all the parameter keys to be inconsistent format.

Copy link
Collaborator

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add a release notes to update these keys to switch to the new one.

@nixpanic
Copy link
Member

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2025

rebase

☑️ Nothing to do, the required conditions are not met

  • any of:
    • #commits > 1 [📌 rebase requirement]
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • -conflict [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]

@nixpanic
Copy link
Member

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 2d95dd3

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Aug 12, 2025
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.32

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.33

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.33

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.33

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Aug 12, 2025
@YiteGu
Copy link
Member Author

YiteGu commented Aug 12, 2025

We can add a release notes to update these keys to switch to the new one.

Can an existing PVC be switched to a new storageclass by modifying the storageClassName?

mergify bot added a commit that referenced this pull request Aug 12, 2025
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 12, 2025

We can add a release notes to update these keys to switch to the new one.

Can an existing PVC be switched to a new storageclass by modifying the storageClassName?

its not possible as these attributes are stored in the PV object, best option is to implement VolumeAttributeClass for this one to change the existing options.

@mergify mergify bot merged commit 2d95dd3 into ceph:devel Aug 12, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/rbd Issues related to RBD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants