-
Couldn't load subscription status.
- Fork 580
rbd: adjust qos parameters start with small case #5488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yite Gu <[email protected]>
0ffcf8d to
c2e07aa
Compare
|
@YiteGu, Can you please add a message in PR description why is this change needed and same in commit message? |
updated. the purpose is very simple. change QOS params to small to align this with other parameters. |
|
This isn't backwards compatible, is that a problem? Existing StorageClasses with the old parameters won't keep functioning when Ceph-CSI is updated to use the new parameters. |
@nixpanic ceph-csi never advertized nbd as supported mounter, its currently kept as alpha feature only https://github.com/ceph/ceph-csi/blob/devel/docs/design/proposals/rbd-nbd.md#status, This change is required to keep all the parameter keys to be inconsistent format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add a release notes to update these keys to switch to the new one.
|
@Mergifyio rebase |
☑️ Nothing to do, the required conditions are not met
|
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 2d95dd3 |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
|
/test ci/centos/mini-e2e/k8s-1.32 |
|
/test ci/centos/k8s-e2e-external-storage/1.33 |
|
/test ci/centos/mini-e2e-helm/k8s-1.33 |
|
/test ci/centos/mini-e2e/k8s-1.33 |
Can an existing PVC be switched to a new storageclass by modifying the storageClassName? |
its not possible as these attributes are stored in the PV object, best option is to implement VolumeAttributeClass for this one to change the existing options. |
Describe what this PR does
we should change this to small to align this with other parameters.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)