Skip to content

Use go install to install controller-gen #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jetstack-bot merged 2 commits into from
Apr 12, 2023
Merged

Use go install to install controller-gen #32

jetstack-bot merged 2 commits into from
Apr 12, 2023

Conversation

@wallrj
Copy link
Member

@wallrj wallrj commented Apr 12, 2023

While upgrading go ( #31 ) I noticed that the installation of controller-gen was broken:

mv: cannot stat '/tmp/tmp.3YSqYnswQb/controller-gen': No such file or directory
make: *** [Makefile:120: /__w/sample-external-issuer/sample-external-issuer/bin/controller-gen-0.5.0] Error 1

-- https://github.com/cert-manager/sample-external-issuer/actions/runs/4676731610/jobs/8283393483?pr=31

wallrj added 2 commits April 12, 2023 12:04
@wallrj
Use go install to install controller-gen
a340575 
Signed-off-by: Richard Wall <[email protected]>
@wallrj
make fmt
37d3a37 
Signed-off-by: Richard Wall <[email protected]>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 12, 2023
@wallrj wallrj requested a review from irbekrm April 12, 2023 11:27
@wallrj wallrj force-pushed the install-controller-gen branch from 1dff703 to 37d3a37 Compare April 12, 2023 11:30
@wallrj wallrj mentioned this pull request Apr 12, 2023
Merged
irbekrm
irbekrm approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wallrj this makes sense

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2023
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Apr 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 905d42e into cert-manager:main Apr 12, 2023
@wallrj wallrj deleted the install-controller-gen branch April 12, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@irbekrm irbekrm irbekrm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@irbekrm irbekrm

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wallrj @jetstack-bot @irbekrm