Skip to content

Conversation

@irbekrm
Copy link
Contributor

@irbekrm irbekrm commented May 11, 2023

This PR bumps dependencies

@jetstack-bot jetstack-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 11, 2023
@irbekrm
Copy link
Contributor Author

irbekrm commented May 11, 2023

Tests currently fail because of c/r changes.

irbekrm added 2 commits May 24, 2023 15:22
Upgrade deps and import c/r from latest master to ensure it's compatible with kube 1.27 libs

Signed-off-by: irbekrm <[email protected]>
Fake client now expects that objects that have status subresource are added to 'withStatusSubresource' collection so that their status gets correctly updated or not updated depending on whether the update/patch operation targets status subresource or not. See kubernetes-sigs/controller-runtime#2259

Signed-off-by: irbekrm <[email protected]>
@inteon
Copy link
Member

inteon commented Jun 1, 2023

/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, irbekrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@inteon
Copy link
Member

inteon commented Jun 1, 2023

/unhold

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2023
@jetstack-bot jetstack-bot merged commit f9858e7 into cert-manager:main Jun 1, 2023
@inteon inteon mentioned this pull request Jun 1, 2023
@irbekrm irbekrm deleted the bump_deps branch June 1, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants