smtp_batch: add feature for grouping and templating #2610
+122
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like discussed in #2586, here is the thing. I already did some manual testing regarding templating the subject string. For this configured
extra.my_template_value
to the events (I did this with the modify bot for now)extra.my_template_value
) to the newadditional_grouping_keys
parametersubject: "Prefix {{ extra_my_template_value }}"
templating: {subject: true}
But probably some tests in the test suite will be needed for this (but I'd like to defer this one after the first feedback round)
Any comments?
Maybe issues to discuss:
hash_arbitrary
template_data
along with eachmail
as a tuplerequirements.txt
?Also I didn't get the testing environment setup correctly until now, so it would be nice if someone could trigger the pipelines yet already so I can check the outputs regarding code-style.