-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix set-cookie parsing #1675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix set-cookie parsing #1675
Conversation
RegEx taken here: dart-lang/http#362 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests.
I have no experience with dart tests, so I am not sure if I can do this, but I will look into it. |
This is easy by expecting a multi-value cookie to be parsed as multi values. An example: Lines 12 to 20 in 62622e2
|
4d809e3
to
58d4e45
Compare
@AlexV525 done |
Sorry, please update the CHANGELOG too. |
@AlexV525 done |
New Pull Request Checklist
main
branch to avoid conflicts (via merge from master or rebase)Additional context and info (if any)
Fix #1674