fix: avoid BigInt literal in closeTo for runtime compat#1748
Merged
43081j merged 2 commits intoNov 21, 2025
Conversation
202db66 to
6dd9de0
Compare
Contributor
Author
|
@snewcomer can i get a review on this ? |
43081j
approved these changes
Nov 21, 2025
Contributor
Author
|
@43081j Quick question on when will this be released ? |
Contributor
|
ill aim to release it in the next couple of days 👍 |
Contributor
Author
|
@43081j do you have plan for the release before the new year ? |
Contributor
|
should be released in 6.2.2 👍 let me know if all is well |
Contributor
Author
|
@43081j thanks a ton :-) Happy Holidays and Merry Christmas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Assertion.closeTo, which causes Hermes (React Native) to fail bundleevaluation with
No identifiers allowed directly after numeric literal.absso the code path stays compatible with engines lacking BigInt literal parsing.Context
0nliteral during bundle load; app crashes before tests run.Change
lib/chai/core/assertions.js: changeconst abs = (x) => (x < 0n ? -x : x);toconst abs = (x < 0 ? -x : x);and document the rationale.
Testing