Skip to content

Add support for sinon v5#122

Merged
domenic merged 3 commits intochaijs:masterfrom
dostu:upgrade-sinon-v5
May 23, 2018
Merged

Add support for sinon v5#122
domenic merged 3 commits intochaijs:masterfrom
dostu:upgrade-sinon-v5

Conversation

@dostu
Copy link
Copy Markdown
Contributor

@dostu dostu commented May 2, 2018 •
edited
Loading

Closes #120

@joovel
Copy link
Copy Markdown

joovel commented May 4, 2018

LGTM

@westy92 westy92 mentioned this pull request May 7, 2018
Closed
@voxpelli
Copy link
Copy Markdown

voxpelli commented May 8, 2018

This should update the Travis-definition as well, see how I did it in my PR: #125

Else it won't test on Sinon 5 there, and it should preferably test with both Sinon 5 and Sinon 4

I'll close my PR in favor of this one though, sorry for not noticing it before I opened mine 🙈

@dostu dostu force-pushed the upgrade-sinon-v5 branch from 55a7fde to aadf7c2 Compare May 8, 2018 18:48
@dostu
Copy link
Copy Markdown
Contributor Author

dostu commented May 8, 2018

Thanks for your feedback, I've updated my PR.

westy92
westy92 approved these changes May 9, 2018
View reviewed changes
Copy link
Copy Markdown

@westy92 westy92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

davesag
davesag approved these changes May 10, 2018
View reviewed changes
Copy link
Copy Markdown

@davesag davesag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@davesag
Copy link
Copy Markdown

davesag commented May 10, 2018

Looking forward to this being merged so I can finally update sinon in my project to v5

@dostu
Copy link
Copy Markdown
Contributor Author

dostu commented May 10, 2018

@domenic, please take a look at this. It would be great if we could merge it and cut a new version.

@domenic
Copy link
Copy Markdown
Collaborator

domenic commented May 10, 2018

Sinon-Chai is a spare-time project; I will hopefully have time to work on it this weekend, but even if I don't, please refrain from further +1 comments.

@nicojs nicojs mentioned this pull request May 11, 2018
Closed
@domenic domenic merged commit 293401a into chaijs:master May 23, 2018
@davesag
Copy link
Copy Markdown

davesag commented May 23, 2018

thanks @domenic — please let us know when this hits NPM. Very eager to upgrade sinon.

@domenic
Copy link
Copy Markdown
Collaborator

domenic commented May 23, 2018

Dang, I did indeed forget to npm publish. Done now.

@dostu dostu deleted the upgrade-sinon-v5 branch May 23, 2018 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@westy92 westy92 westy92 approved these changes

@davesag davesag davesag approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dostu @joovel @voxpelli @davesag @domenic @westy92