Skip to content

Conversation

@msgmaxim
Copy link
Contributor

@msgmaxim msgmaxim commented Jan 13, 2026

Pull Request

Summary

This simply moves most of the p2p module out of chainflip-engine into a separate crate. In theory this should result is slightly faster re-compilation of chainflip-engine (I measured about 1s reduction on average in a debug build). Clean compilation should also improve as engine-p2p can now be compiled in parallel to other code before chainflip-engine, and chainflip-engine is one of the biggest bottlenecks (as reported by cargo build --timings). Admittedly, the savings are small (due to p2p being a small fraction of the code), but it was an easy change to make, and if nothing else I think this change makes sense conceptually.

@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
engine/p2p/src/lib.rs 84% 3 Missing ⚠️
engine/src/p2p.rs 0% 2 Missing ⚠️
engine/src/p2p/peer_info_submitter.rs 0% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants