refactor: Separate engine/p2p crate #6356
Open
+180
−108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
This simply moves most of the p2p module out of
chainflip-engineinto a separate crate. In theory this should result is slightly faster re-compilation ofchainflip-engine(I measured about 1s reduction on average in a debug build). Clean compilation should also improve asengine-p2pcan now be compiled in parallel to other code beforechainflip-engine, andchainflip-engineis one of the biggest bottlenecks (as reported bycargo build --timings). Admittedly, the savings are small (due to p2p being a small fraction of the code), but it was an easy change to make, and if nothing else I think this change makes sense conceptually.