Add String functions to filesystem implementations#2008
Open
inteon wants to merge 1 commit intochainguard-dev:mainfrom
Open
Add String functions to filesystem implementations#2008inteon wants to merge 1 commit intochainguard-dev:mainfrom
inteon wants to merge 1 commit intochainguard-dev:mainfrom
Conversation
inteon
commented
Jan 12, 2026
| } | ||
| } | ||
|
|
||
| func (m *memFS) String() string { |
Author
There was a problem hiding this comment.
We could potentially add this function to the FullFS interface, but this would be a breaking change, WDYT?
inteon
force-pushed
the
add_string_to_fs
branch
from
36bec2d to
d1704da
Compare
In error messages, filesystems are often printed (eg. 'fmt.Errorf("could not open repositories file in %s", a.fs)'). Without String function, this resulted in unreadable error messages.
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
force-pushed
the
add_string_to_fs
branch
from
d1704da to
22188f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In error messages, filesystems are often printed (eg.
apko/pkg/apk/apk/repo.go
Line 129 in db9be70
Without String function, this resulted in unreadable error messages:
This is the new error message: