tests: improve passwd/group parsing tests#2045
Merged
imjasonh merged 1 commit intochainguard-dev:mainfrom Jan 31, 2026
Merged
Conversation
The tests that are supposed to validate that existing passwd and group files are being parsed correctly didn't actually verify that any elements were successfully returned from the parse operation. This meant that an exploratory patch that converted apkofs.DirFS() to tarfs() looked like it succeeded but actually didn't. Fix this by ensuring that the checked for entries are actually found and also expand the fields checked in the passwd and group dbs. Signed-off-by: Steve Beattie <[email protected]>
imjasonh
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests that are supposed to validate that existing passwd and group files are being parsed correctly didn't actually verify that any elements were successfully returned from the parse operation. This meant that an exploratory patch that converted apkofs.DirFS() to tarfs() looked like it succeeded but actually didn't.
Fix this by ensuring that the checked for entries are actually found and also expand the fields checked in the passwd and group dbs.
Doing this highlighted one particular behavior quirk that I'm not sure is intended: if the user member list in an
/etc/groupentry is empty, the group parsing function returns a string slice with one element containing an empty string i.e.[]string{""}(length 1) and not an an empty slice[]string{}(length 0). I'm not sure it matters in how the data structure is used, as the write methods generate byte-for-byte equivalents as demonstrated by the group TestWriter() test.