e2e-tests: Always run tests with all compatible runners#2135
Draft
justinvreeland wants to merge 1 commit intochainguard-dev:mainfrom
Draft
e2e-tests: Always run tests with all compatible runners#2135justinvreeland wants to merge 1 commit intochainguard-dev:mainfrom
justinvreeland wants to merge 1 commit intochainguard-dev:mainfrom
Conversation
Contributor
Author
|
Looks like CI has a different set of failures than I see locally though: |
Member
|
The difference you're seeing between CI and local may be due to running as non-root locally versus as root in the CI runner; both the bubblewrap and docker runners have subtle differences in behavior in those situations due to the outside world leaking in. I do like this change, I wanted to run against all three runners when developing #2138 and also want to see them get run in CI. |
8889a42 to
51439cd
Compare
This way we'll notice when things break even if they defaults have changed. Darwin doesn't support bubble wrap but macOS 26 has native container, might be interesting.
51439cd to
f8fa430
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't take that much longer to run these tests with the additional runners. It would be nice to have a switch to select that but I didn't want to spend too much time on it. This is roughly on top of #2134 but has divered once I realized I wouldn't be able to fix the failing tests easily.
For example on x86_64 linux we have the following tests that fail with both the same for x86_64 testing and aarch64 testing/