[misc] Prepare for 1.12.0 release #1061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkmartinjr
approved these changes
Mar 21, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
=======================================
Coverage 81.33% 81.33%
=======================================
Files 73 73
Lines 5566 5566
=======================================
Hits 4527 4527
Misses 1039 1039
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
prathapsridharan
force-pushed
the
psridharan/census-rel-1.12.0
branch
from
f97b2c5 to
1cf85aa
Compare
prathapsridharan
force-pushed
the
psridharan/census-rel-1.12.0
branch
from
1cf85aa to
3f734a4
Compare
bkmartinjr
reviewed
Mar 28, 2024
| # ensure that the assets are readable (tiledbsoma supports backward compatible reading). | ||
| # Make sure this version does not fall behind the builder's tiledbsoma version. | ||
| "tiledbsoma~=1.8.0", | ||
| # TODO: When ready to release 1.12.0 update tiledbsoma version to 1.9.x and delete this temporary comment |
Contributor
There was a problem hiding this comment.
time to delete the comment?
BTW, I believe ~=1.9.1 means anything >1.9.1 and <1.10.0, so this pin should be fine (1.9.0 never existed in the wild)
Contributor
Author
There was a problem hiding this comment.
will remove comment.
I believe ~=1.9.1
Yea that is my understanding too
bkmartinjr
approved these changes
Mar 28, 2024
Contributor
bkmartinjr
left a comment
bkmartinjr
left a comment
There was a problem hiding this comment.
One minor point/nit, but otherwise LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release of the census package is being done to include an important update for
tiledbsomain1.9.0which includes a fix to categorical columns. To ensure that this release goes smoothly, we will:TileDB-SOMAmainbranch which contains the fixes that will go into1.9.0. We can think of this as a pre-release acceptance testtiledbsoma==1.9.0, we will update the dependencies in this PR to point totiledbsoma==1.9.0and do the official release ofcellxgene-census==1.12.0