Skip to content

Conversation

@ebezzi
Copy link
Member

@ebezzi ebezzi commented May 6, 2024

Some of the imports in test_pytorch.py were causing the tests to fail even if they were not invoked (as in, not in experimental mode). This should fix the issue.

@codecov
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.12%. Comparing base (8fb99b3) to head (b55bc45).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1129   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files          77       77           
  Lines        5857     5857           
=======================================
  Hits         5337     5337           
  Misses        520      520           
Flag Coverage Δ
unittests 91.12% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@prathapsridharan prathapsridharan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ebezzi ebezzi merged commit c6f827b into main May 7, 2024
@ebezzi ebezzi deleted the ebezzi/fix-pytorch-imports branch May 7, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants