[builder] Upgrade to CELLxGENE schema 5.1 #1192
Conversation
| CENSUS_SCHEMA_VERSION = "2.0.1" | ||
|
|
||
| CXG_SCHEMA_VERSION = "5.0.0" # the CELLxGENE schema version supported | ||
| CXG_SCHEMA_VERSION = "5.1.0" # the CELLxGENE schema version supported |
There was a problem hiding this comment.
@ebezzi @atolopko-czi - Should CENSUS_SCHEMA_VERSION also be bumped? If so, is it a patch or minor version bump?
There was a problem hiding this comment.
I would only bump if there are noticeable and traceable changes (e.g. major ontology changes, new/removed assays). We should be able to add some doc changes if we bump it.
There was a problem hiding this comment.
Yes we need to bump the minor version number, and see my comment.
#1194 (comment)
ebezzi
left a comment
ebezzi
left a comment
There was a problem hiding this comment.
Requesting one change related to dependency pins.
Also, is there a changelog for the 5.0 -> 5.1 schema bump? This will determine how thoroughly this change should be tested.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1192 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 77 77
Lines 5922 5922
=======================================
Hits 5396 5396
Misses 526 526
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ebezzi
changed the title
Reason
changes
Blocking: chanzuckerberg/single-cell-data-portal#7078