Skip to content

Conversation

@mlin
Copy link
Contributor

@mlin mlin commented Jul 12, 2024

No description provided.

@mlin mlin requested review from ivirshup and pablo-gar July 12, 2024 05:58
@codecov
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.26%. Comparing base (5cbad99) to head (4eda6da).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1241   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files          80       80           
  Lines        6330     6330           
=======================================
  Hits         5777     5777           
  Misses        553      553           
Flag Coverage Δ
unittests 91.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pablo-gar pablo-gar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlin I moved the notebook the right location and created the necessary symlink for the doc-site.

I've also updated the title to be more descriptive.

It was failing lint so I made the needed changes for that as well

@mlin mlin merged commit a6ad2a9 into main Jul 15, 2024
@mlin mlin deleted the mlin/embeddings-search-notebook branch July 15, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants