Skip to content

Conversation

@pablo-gar
Copy link
Collaborator

No description provided.

@pablo-gar pablo-gar requested review from ivirshup and mlin August 30, 2024 22:39
@codecov
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.41%. Comparing base (8ed87c4) to head (ee5a4df).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1270   +/-   ##
=======================================
  Coverage   91.41%   91.41%           
=======================================
  Files          82       82           
  Lines        6463     6463           
=======================================
  Hits         5908     5908           
  Misses        555      555           
Flag Coverage Δ
unittests 91.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mlin mlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining lint error appears to be unrelated (?)

@ivirshup ivirshup merged commit 60c12f6 into main Sep 4, 2024
@ivirshup ivirshup deleted the pablo-gar/update-similarity-notebook branch September 4, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants