fix: remove depguard from happy linter (CCIE-4307) #3937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lint had a breaking change a while back involving depguard drastically rewriting the structure of its config (golangci/golangci-lint#3906) . I took a stab at rewriting to meet the new standard (https://golangci-lint.run/usage/linters/#depguard) but in realizing what this specific linter did, it didn't seem worth debugging the associated versioning and formatting issues. As this specific linter was primarily being used to ensure we were not using incorrect error packages, and doesn't otherwise monitor the health of the application, I think it can be safely removed. It's more important to get this linter passing overall so that we can push through dependabot fixes.
jacoblerner-czi
requested review from
alexlokshin-czi
and removed request for
a team
Contributor
|
No Jira issue reference found in branch, title, or body of PR. Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR. |
jakeyheath
approved these changes
Mar 27, 2025
jacoblerner-czi
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCIE-4307
Lint had a breaking change a while back involving depguard drastically rewriting the structure of its config (golangci/golangci-lint#3906) . I took a stab at rewriting to meet the new standard (https://golangci-lint.run/usage/linters/#depguard) but in realizing what this specific linter did, it didn't seem worth debugging the associated versioning and formatting issues. As this specific linter was primarily being used to ensure we were not using incorrect error packages, and doesn't otherwise monitor the health of the application, I think it can be safely removed. It's more important to get this linter passing overall so that we can push through dependabot fixes.