Skip to content

feat: add ability to blacklist and remove georestriction in happy cloudfront (CCIE-4360) #3943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 7, 2025
Merged

feat: add ability to blacklist and remove georestriction in happy cloudfront (CCIE-4360) #3943

merged 4 commits into from
Apr 7, 2025

Conversation

@kuannie1
Copy link
Contributor

@kuannie1 kuannie1 commented Apr 2, 2025 •
edited by github-actions bot
Loading

CCIE-4360
Summary enhance happy cloudfront module to include more geo restrictions
Type Task Task
Status In Progress

the default is whitelist like before, but this additional variable will help us use the full extent of the geo restriction types.

@kuannie1 kuannie1 requested a review from a team as a code owner April 2, 2025 17:07
@kuannie1 kuannie1 requested review from abiju-czi and removed request for a team April 2, 2025 17:07
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

No Jira issue reference found in branch, title, or body of PR.

Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR.

@abiju-czi
Copy link
Contributor

abiju-czi commented Apr 2, 2025

Lets hold off on any updates till they get a chance to get back to us

alexlokshin-czi
alexlokshin-czi reviewed Apr 2, 2025
View reviewed changes
terraform/modules/happy-cloudfront/main.tf
geo_restriction {
locations = var.geo_restriction_locations
restriction_type = "whitelist"
restriction_type = var.geo_restriction_type
Copy link
Contributor

@alexlokshin-czi alexlokshin-czi Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a chance you will need multiple restrictions with different restriction types?

Copy link
Contributor Author

@kuannie1 kuannie1 Apr 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibly. I'll talk to you about them.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

No Jira issue reference found in branch, title, or body of PR.

Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

No Jira issue reference found in branch, title, or body of PR.

Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

No Jira issue reference found in branch, title, or body of PR.

Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR.

@kuannie1 kuannie1 marked this pull request as draft April 2, 2025 17:13
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

No Jira issue reference found in branch, title, or body of PR.

Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR.

@kuannie1 kuannie1 marked this pull request as ready for review April 7, 2025 16:36
@kuannie1 kuannie1 changed the title feat: add ability to blacklist and remove georestriction in happy cloudfront feat(SECENG-767): add ability to blacklist and remove georestriction in happy cloudfront Apr 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

No Jira issue reference found in branch, title, or body of PR.

Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR.

@kuannie1 kuannie1 changed the title feat(SECENG-767): add ability to blacklist and remove georestriction in happy cloudfront feat: add ability to blacklist and remove georestriction in happy cloudfront (SECENG-767) Apr 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

No Jira issue reference found in branch, title, or body of PR.

Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR.

@kuannie1 kuannie1 changed the title feat: add ability to blacklist and remove georestriction in happy cloudfront (SECENG-767) feat: add ability to blacklist and remove georestriction in happy cloudfront (CCIE-4360) Apr 7, 2025
@kuannie1 kuannie1 enabled auto-merge (squash) April 7, 2025 16:48
@kuannie1 kuannie1 merged commit 69d1ad7 into main Apr 7, 2025
34 of 38 checks passed
@kuannie1 kuannie1 deleted the aku/add-cloudfront-ability-to-remove-geo-restrictions branch April 7, 2025 16:49
@czi-github-helper czi-github-helper bot mentioned this pull request Apr 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexlokshin-czi alexlokshin-czi alexlokshin-czi approved these changes

+1 more reviewer

@abiju-czi abiju-czi abiju-czi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kuannie1 @abiju-czi @alexlokshin-czi