Skip to content

Conversation

@nayib-jose-gloria
Copy link
Contributor

Reason for Change

  • memory spikes on dense matrices in prod, don't need to convert those to COO to enable dask summation

Changes

  • don't convert dense matrices to COO

@nayib-jose-gloria nayib-jose-gloria changed the title Nayib/fix feature is filtered fix: don't convert dense matrices to COO in feature_is_filtered validation Jul 7, 2025
@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@468f06f). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1398   +/-   ##
=======================================
  Coverage        ?   89.17%           
=======================================
  Files           ?       23           
  Lines           ?     2587           
  Branches        ?        0           
=======================================
  Hits            ?     2307           
  Misses          ?      280           
  Partials        ?        0           
Components Coverage Δ
cellxgene_schema_cli 89.72% <100.00%> (?)
migration_assistant 91.26% <ø> (?)
schema_bump_dry_run_genes 79.74% <ø> (?)
schema_bump_dry_run_ontologies 99.51% <ø> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nayib-jose-gloria nayib-jose-gloria merged commit bdabf64 into main Jul 7, 2025
16 checks passed
@nayib-jose-gloria nayib-jose-gloria deleted the nayib/fix-feature-is-filtered branch July 7, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants