Skip to content

Conversation

@joyceyan
Copy link
Contributor

Reason for Change

https://czi-sci.slack.com/archives/C07AV4NU9D2/p1755897599662919?thread_ts=1755889725.833399&cid=C07AV4NU9D2

Changes

  • replaces return with continue, so that we append errors for each invalid gene

Testing

updated an existing test we had to ensure we would return 2 errors for 2 invalid genes

Notes for Reviewer

@joyceyan joyceyan requested review from Bento007 and kliu-czi August 25, 2025 17:33
@codecov
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.99%. Comparing base (68f1b39) to head (610fe11).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1432      +/-   ##
==========================================
- Coverage   89.03%   88.99%   -0.04%     
==========================================
  Files          23       23              
  Lines        2580     2580              
==========================================
- Hits         2297     2296       -1     
- Misses        283      284       +1     
Components Coverage Δ
cellxgene_schema_cli 89.48% <100.00%> (-0.06%) ⬇️
migration_assistant 91.26% <ø> (ø)
schema_bump_dry_run_genes 79.74% <ø> (ø)
schema_bump_dry_run_ontologies 99.51% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joyceyan joyceyan merged commit 3cac00e into main Aug 25, 2025
15 of 17 checks passed
@joyceyan joyceyan deleted the joyce/fix-invalid-gene-check branch August 25, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants