-
Notifications
You must be signed in to change notification settings - Fork 28
fix: improve error handling for subprocess commands in atac_seq.py #1446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves error handling for subprocess commands in the ATAC-seq pipeline by adding comprehensive error checking for all processes in the command pipelines. Previously, only the final bgzip process was checked for errors, potentially allowing earlier pipeline failures to go unnoticed.
- Enhanced error handling to check return codes of all subprocess commands in pipelines
- Consolidated error reporting by collecting all failures and presenting them together
- Replaced single-process error checking with comprehensive multi-process validation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1446 +/- ##
==========================================
- Coverage 88.69% 88.50% -0.20%
==========================================
Files 23 23
Lines 2646 2662 +16
==========================================
+ Hits 2347 2356 +9
- Misses 299 306 +7
🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <[email protected]>
…1446) Co-authored-by: Copilot <[email protected]>
Reason for Change
Notes for Reviewer