Skip to content

Conversation

@atarashansky
Copy link
Contributor

Reason for Change

  • #TICKET_NUMBER
  • If the reason for this PR's code changes are not clear in the issue, state value/impact

Changes

  • add
  • remove
  • modify

Testing steps

  • Either list QA steps or reasoning you feel QA is unnecessary
  • Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.
  • "Unit tested only", "tested in rdev by a, b, c, verifying feature worked by... ", "manually ran pipeline locally with these results: ..."

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions
  • For UI changes, verify impacted analytics events still work

Notes for Reviewer

@github-actions
Copy link
Contributor

Deployment Summary

@atarashansky atarashansky marked this pull request as draft May 22, 2024 21:16
@atarashansky atarashansky force-pushed the atar-czde-oai-nostream branch from e01c049 to 15dd8fc Compare May 22, 2024 21:19
@codecov
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 32.55814% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 91.87%. Comparing base (6c72fef) to head (15dd8fc).

Files Patch % Lines
backend/de/api/utils.py 28.57% 15 Missing ⚠️
backend/de/api/v1.py 23.07% 10 Missing ⚠️
backend/de/api/config.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7088      +/-   ##
==========================================
- Coverage   92.03%   91.87%   -0.17%     
==========================================
  Files         186      188       +2     
  Lines       15853    15896      +43     
==========================================
+ Hits        14590    14604      +14     
- Misses       1263     1292      +29     
Flag Coverage Δ
unittests 91.87% <32.55%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants