Skip to content

use container name in dictionary instead of pod's to return logs #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use container name in dictionary instead of pod's to return logs #100

wants to merge 1 commit into from

Conversation

myroslavrozum
Copy link

No description provided.

@myroslavrozum myroslavrozum force-pushed the containerNameInsteadOfPod branch from 71b8b07 to 27ec6bb Compare September 23, 2020 15:21
Lawouach
Lawouach requested changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@Lawouach Lawouach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there,

This is a useful change I think. But for the merge I'd need tests and changelog entries please.

And maybe a rebase from master.

@myroslavrozum myroslavrozum force-pushed the containerNameInsteadOfPod branch from 27ec6bb to 17b4e05 Compare September 28, 2020 22:36
use container name in dictionary instead of pod's to return logs
adc4436 
Signed-off-by: Myroslav Rozum <[email protected]>

[95] add CHANGELOG entry
@myroslavrozum myroslavrozum force-pushed the containerNameInsteadOfPod branch from 17b4e05 to adc4436 Compare September 28, 2020 22:48
@myroslavrozum
Copy link
Author

myroslavrozum commented Sep 28, 2020 •
edited
Loading

Hi!

Hey there,

This is a useful change I think. But for the merge I'd need tests and changelog entries please.

  • CHANGELOG is done.
  • I thought tests are tests/test_probes.py i there anything else to add?

And maybe a rebase from master.
done as well.

@myroslavrozum myroslavrozum requested a review from Lawouach October 5, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lawouach Lawouach Awaiting requested review from Lawouach

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@myroslavrozum @Lawouach