Update build scripts to allow RV 10 to build #16063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per suggestion of RV authors cdl-saarland/rv#44
e-kayrakli
approved these changes
Jul 15, 2020
| include $(THIRD_PARTY_DIR)/llvm/Makefile.share-included | ||
|
|
||
| # Enable RV and Polly if they are in the source directory | ||
| LLVM_RV_FILE = $(LLVM_DIR)/$(LLVM_SUBDIR)/tools/rv/ |
Contributor
There was a problem hiding this comment.
Are we keeping this for backwards compatibility?
Member
Author
There was a problem hiding this comment.
I left it in because I'm not sure if it will be needed or not in the future if we start to bundle RV.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
./update-llvm.sh release/10.xand a subsequentmaketobuild RV. It adjusts the script and Makefiles to expect RV to be in
llvm-project/rvwhich is the expected location according to the RVauthors. It fixes an error where the
llvm-projectclone was alwaysusing the master branch instead of the requested release.
Additionally it adjusts the LLVM build step to print out the
cmakecommand because I am always wanting to check it for errors when things
are going wrong and I don't know of another easy way to do that.
While there, resolves #14038 by adding
-DCLANG_ANALYZER_ENABLE_Z3_SOLVER=0to the cmake command.Reviewed by @e-kayrakli - thanks!