Fix rendering of throws, allowing it to co-exist with return intents
#103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Abraham <[email protected]>
…f logic Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
lydia-duncan
approved these changes
Jun 27, 2025
Member
lydia-duncan
left a comment
lydia-duncan
left a comment
There was a problem hiding this comment.
Just two comment adjustments, otherwise this is really good, thank you!
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
jabraham17
added a commit
to chapel-lang/chapel
that referenced
this pull request
Jul 1, 2025
Resolves a TODO in the `Map` docs which was blocked by a chpldoc/chapeldomain bug. That [bug](#23776) is fixed with chapel-lang/sphinxcontrib-chapeldomain#103 and #27468, so the TODO can be resolved [Reviewed by @ShreyasKhandekar]
jabraham17
added a commit
that referenced
this pull request
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
throwsand a return intent would break parsing of chapel signatures. This was because the parser was capturingthrowsand treating it like a return intent, so it didn't know what to do with the actual return intent.To implement this, I actually had to fix several things
const throwswould get treated as a single intent, which is not correct. This required me to add a special function to fixup the regex match.Fixes the issue described in chapel-lang/chapel#23776, once this fix propagates to Chapel main.
[Reviewed by @lydia-duncan]