Skip to content

Conversation

@jabraham17
Copy link
Member

@jabraham17 jabraham17 commented Mar 4, 2024

Fixes how return intents (and by proxy return types) are formatted in chromium based browsers

Before this PR
Screenshot 2024-03-04 at 9 50 12 AM
Screenshot 2024-03-04 at 1 31 01 PM

After this PR
Screenshot 2024-03-04 at 9 50 22 AM
Screenshot 2024-03-04 at 1 29 52 PM

[Reviewed by @lydia-duncan]

Signed-off-by: Jade Abraham <[email protected]>
@jabraham17 jabraham17 requested a review from lydia-duncan March 4, 2024 18:53
Copy link
Member

@lydia-duncan lydia-duncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, but it looks like you need to get the linter to pass by making the lines shorter :)

Can you post a comparison for a function with just a return type, and have you checked how Firefox responds to your change (since Firefox was working before)?

@jabraham17
Copy link
Member Author

I just updated the OP to include a comparison with just a return type. I also did check against firefox and safari, it renders correctly. The only chromium browser I tested was Chrome, but I assume Edge (and others?) will be the same.

Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
@codecov
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 42.07%. Comparing base (f652bb9) to head (515d516).

Files Patch % Lines
sphinxcontrib/chapeldomain/__init__.py 10.52% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   42.25%   42.07%   -0.18%     
==========================================
  Files           2        2              
  Lines         542      549       +7     
==========================================
+ Hits          229      231       +2     
- Misses        313      318       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jabraham17 jabraham17 merged commit 8a50be5 into chapel-lang:main Mar 4, 2024
@jabraham17 jabraham17 deleted the fix-return-intent branch March 4, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants