-
Notifications
You must be signed in to change notification settings - Fork 16
Update dependencies: docutils 0.20.1, Sphinx 7.2.6 #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
--- Signed-off-by: Michael Ferguson <[email protected]>
also pass 'name=' for what appear to be names for the Mock objects --- Signed-off-by: Michael Ferguson <[email protected]>
lydia-duncan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
This PR updates the chpldoc requirements to the newest versions. I tried this because I was thinking about adjustment to the search box, and I wanted to see if the newer versions of Sphinx behave differently. (They do not seem to). Sphinx 7.2.6 requires Python >= 3.9, so this PR updates prereqs.rst to list 3.9 as required for chpldoc, start_test, and c2chapel. (The previous requirement for these was Python 3.7). It adds the sphinx extension `sphinxcontrib.jquery` to `conf.py` because the search box from sphinx-rtd-theme now uses jquery. | package | version before this PR | version after this PR | | ------- | ---------------------- | --------------------- | | MarkupSafe | 2.1.3 | 2.1.5 | | Sphinx | 5.3.0 | 7.2.6 | | urllib3 | 2.1.0 | 2.2.1 | | docutils | 0.18 | 0.20.1 | | sphinxcontrib-chapeldomain | 0.0.31 | 0.0.32 | (note that chapel-lang/sphinxcontrib-chapeldomain#92 updated sphinxcontrib-chapeldomain in a coordinated manner: docutils 0.18 -> 0.20.1 and Sphinx 5.3.0 -> 7.2.6. The result of that PR is available in sphinxcontrib-chapeldomain version 0.0.32.) Reviewed by @lydia-duncan - thanks! - [x] full comm=none testing
|
@mppf -- have you tried with a newer version of docutils? docutils is a secondary dependency to Arkouda. When installing its client, we end up pulling a newer docutils. Then, for some reason, when we are trying to build our venv, we hit I would have expected pip to be able to handle such things, but that doesn't seem to be the case. We could (1) add docutil dependency to ARkouda with the correct version, (2) make our nightly testing not build Ideally, I want to understand why pip is unable to handle this, but quickly googling about it didn't lead anywhere particularly useful for our case. |
|
I don't know if Michael has, but I have #100 |
I suppose this is running a venv-in-a-venv...
I think (1) would work, but I don't think (2) would work, because AFAK our If you aren't using |
Oh, thanks, Lydia! Obviously, I didn't do enough sleuthing before commenting here. I think merging that can help. That being said, I am not sure if this error is something we should care too much about. I see blue testing configs that finish successfully despite that. It still needs to be addressed, but probably doesn't hurt something important for testing today.
Ah, interesting. I do use |
This is to go along with chapel-lang/chapel#24612 . The changes to test/test_chapeldomain.py avoid a problem when using docutils 0.19 or newer that came up with the way the test was using mocked objects.
Reviewed by @lydia-duncan - thanks!