Skip to content

Conversation

@mppf
Copy link
Member

@mppf mppf commented Apr 8, 2024

This is to go along with chapel-lang/chapel#24612 . The changes to test/test_chapeldomain.py avoid a problem when using docutils 0.19 or newer that came up with the way the test was using mocked objects.

Reviewed by @lydia-duncan - thanks!

also pass 'name=' for what appear to be names for the Mock objects

---
Signed-off-by: Michael Ferguson <[email protected]>
Copy link
Member

@lydia-duncan lydia-duncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mppf mppf merged commit 30ee1fc into chapel-lang:main Apr 8, 2024
@mppf mppf deleted the sphinx-7.2.6 branch April 8, 2024 17:23
mppf added a commit to chapel-lang/chapel that referenced this pull request Apr 9, 2024
This PR updates the chpldoc requirements to the newest versions. I tried
this because I was thinking about adjustment to the search box, and I
wanted to see if the newer versions of Sphinx behave differently. (They
do not seem to).

Sphinx 7.2.6 requires Python >= 3.9, so this PR updates prereqs.rst to
list 3.9 as required for chpldoc, start_test, and c2chapel. (The
previous requirement for these was Python 3.7).

It adds the sphinx extension `sphinxcontrib.jquery` to `conf.py` because
the search box from sphinx-rtd-theme now uses jquery.

| package | version before this PR | version after this PR |
| ------- | ---------------------- | --------------------- |
| MarkupSafe | 2.1.3 | 2.1.5 |
| Sphinx | 5.3.0 | 7.2.6 |
| urllib3 | 2.1.0 | 2.2.1 |
| docutils | 0.18 | 0.20.1 |
| sphinxcontrib-chapeldomain | 0.0.31 | 0.0.32 |

(note that
chapel-lang/sphinxcontrib-chapeldomain#92
updated sphinxcontrib-chapeldomain in a coordinated manner: docutils
0.18 -> 0.20.1 and Sphinx 5.3.0 -> 7.2.6. The result of that PR is
available in sphinxcontrib-chapeldomain version 0.0.32.)

Reviewed by @lydia-duncan - thanks!

- [x] full comm=none testing
@e-kayrakli
Copy link
Contributor

@mppf -- have you tried with a newer version of docutils?

docutils is a secondary dependency to Arkouda. When installing its client, we end up pulling a newer docutils. Then, for some reason, when we are trying to build our venv, we hit pip's dependency resolver does not currently take into account all the packages that are installed where docutils version mismatch is called out.

I would have expected pip to be able to handle such things, but that doesn't seem to be the case. We could (1) add docutil dependency to ARkouda with the correct version, (2) make our nightly testing not build chpldoc (?) as alternatives. Naively, bumping this version could be a nicer solution.

Ideally, I want to understand why pip is unable to handle this, but quickly googling about it didn't lead anywhere particularly useful for our case.

@lydia-duncan
Copy link
Member

I don't know if Michael has, but I have #100

@mppf
Copy link
Member Author

mppf commented Feb 12, 2025

docutils is a secondary dependency to Arkouda. When installing its client, we end up pulling a newer docutils. Then, for some reason, when we are trying to build our venv, we hit pip's dependency resolver does not currently take into account all the packages that are installed where docutils version mismatch is called out.

I suppose this is running a venv-in-a-venv...

I would have expected pip to be able to handle such things, but that doesn't seem to be the case. We could (1) add docutil dependency to ARkouda with the correct version, (2) make our nightly testing not build chpldoc (?) as alternatives. Naively, bumping this version could be a nicer solution.

I think (1) would work, but I don't think (2) would work, because AFAK our chpl-venv is monolithic and includes the dependencies for both start_test and for the docs build & I assume you are using start_test.

If you aren't using start_test then I think it's a good option.

@e-kayrakli
Copy link
Contributor

I don't know if Michael has, but I have #100

Oh, thanks, Lydia! Obviously, I didn't do enough sleuthing before commenting here. I think merging that can help. That being said, I am not sure if this error is something we should care too much about. I see blue testing configs that finish successfully despite that. It still needs to be addressed, but probably doesn't hurt something important for testing today.

would work, because AFAK our chpl-venv is monolithic and includes the dependencies for both start_test and for the docs build & I assume you are using start_test

Ah, interesting. I do use start_test, so this is not an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants