internal/dirent: fix tests on s390x #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes tests on s390x (big-endian) by removing TestReadInt, which really only existed for code coverage. Fixes #61
This was referenced Sep 4, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 59.20% 58.20% -1.00%
==========================================
Files 12 12
Lines 804 804
==========================================
- Hits 476 468 -8
- Misses 314 322 +8
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
QuLogic
approved these changes
Sep 7, 2025
QuLogic
left a comment
QuLogic
left a comment
There was a problem hiding this comment.
This is good on all arches I can try: https://koji.fedoraproject.org/koji/taskinfo?taskID=136855758
Owner
Author
|
@QuLogic Thank you again for testing this and do you need for me to cut a new release that includes this change? |
|
It wasn't strictly necessary, but thanks for the new release all the same! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes tests on s390x (big-endian) by removing TestReadInt, which really only existed for code coverage.
Fixes #61