darwin/arm64: use the number of perf cores as the default number of workers #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlievieth
force-pushed
the
cev/darwin-max-procs
branch
from
4d4d4a7 to
eb18b65
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #68 +/- ##
==========================================
- Coverage 59.61% 59.24% -0.38%
==========================================
Files 12 13 +1
Lines 629 633 +4
==========================================
Hits 375 375
- Misses 240 244 +4
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
charlievieth
force-pushed
the
cev/darwin-max-procs
branch
from
eb18b65 to
ca23722
Compare
…orkers
Starting around macOS v15 the parallel performance of the APFS file
system appears slightly improved and now the ideal number of fastwalk
workers is generally the number of performance cores currently
available.
Therefore, this commit changes the default number of workers on
darwin/arm64 to be the value of sysctl("hw.perflevel0.physicalcpu")
which is the number of currently available performance cores (link to
xnu source below).
https://github.com/apple-oss-distributions/xnu/blob/43a90889846e00bfb5cf1d255cdc0a701a1e05a4/bsd/sys/sysctl.h#L1244
charlievieth
force-pushed
the
cev/darwin-max-procs
branch
from
ca23722 to
2f021d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting around macOS v15 the parallel performance of the APFS file system appears slightly improved and now the ideal number of fastwalk workers is generally the number of performance cores currently available.
Therefore, this commit changes the default number of workers on darwin/arm64 to be the value of sysctl("hw.perflevel0.physicalcpu") which is the number of currently available performance cores (link to xnu source below).
github.com/apple-oss-distributions/xnu/blob/43a9088/bsd/sys/sysctl.h#L1244