chore(spinner): remove provisional spinner lifetime stuff#112
Merged
meowgorithm merged 1 commit intomasterfrom Mar 31, 2022
Merged
chore(spinner): remove provisional spinner lifetime stuff#112meowgorithm merged 1 commit intomasterfrom
meowgorithm merged 1 commit intomasterfrom
Conversation
The design was overly complicated, especially for such subtle benefits.
meowgorithm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The design was overly complicated, especially for such subtle benefits. Removing this feature simplifies the codebase as well as the codebase of projects that would potentially use this feature.
This (provisional) feature was originally was aded for Glow, and because of its complexity there's a high likelihood that there are any other projects taking advantage of it.