Skip to content

Delegate Cursor Logic to cursor bubble#181

Merged
maaslalani merged 3 commits intomasterfrom
input-cursor
Sep 14, 2022
Merged

Delegate Cursor Logic to cursor bubble#181
maaslalani merged 3 commits intomasterfrom
input-cursor

Conversation

@maaslalani
Copy link
Copy Markdown
Contributor

This PR extracts the original cursor logic to the cursor bubble.

Comment thread textinput/textinput.go
// Cursor returns the cursor position.
func (m Model) Cursor() int {
// Position returns the cursor position.
func (m Model) Position() int {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Breaking change! Since I use the name Cursor for the cursor.Model.

@maaslalani maaslalani force-pushed the input-cursor branch 3 times, most recently from 3a66598 to 80324e5 Compare July 7, 2022 14:41
@maaslalani maaslalani merged commit a99b55c into master Sep 14, 2022
@maaslalani maaslalani deleted the input-cursor branch September 14, 2022 14:44
ReallyLiri pushed a commit to ReallyLiri/bubbles that referenced this pull request Jun 13, 2024
* refactor: remove cursor logic from textinput
* chore: Add Deprecated Fields to avoid breaking changes
* fix: Ctrl+A and typing moves to end bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant