fix(textarea): ensure viewport content is set during update #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the viewport content is set and persisted correctly. Setting the content during View won't doesn't work because it mutates a copy of the model instead without persisting the changes. Moreover, any after effects of setting the content won't be visible because the next Update will be called on the older model, not the new one.
aymanbagabas
requested review from
meowgorithm,
caarlos0,
andreynering and
a team
meowgorithm
approved these changes
Aug 1, 2025
aymanbagabas
added a commit
to charmbracelet/crush
that referenced
this pull request
Aug 1, 2025
…0-c4068c642c90 This fixes a bug where the editor won't scroll after paste. See charmbracelet/bubbles#822
caarlos0
approved these changes
Aug 1, 2025
raphamorim
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the viewport content is set and persisted correctly. Setting the content during View doesn't work because it mutates a copy of the model instead without persisting the changes. Moreover, any after effects of setting the content won't be visible because the next Update will be called on the older model, not the new one.