-
Notifications
You must be signed in to change notification settings - Fork 244
Adds 16colors style #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Adds 16colors style #132
Conversation
Colorful theme loosely based on the Dracula theme for 8-16 color terminals
|
We need to generate and include this style as a Go code. |
autra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi \o I was precisely looking for that, thanks!
I made some comments with some improvements I believe. As this hasn't been touched for a while, I can also take over if that's ok for you @ceuk
| }, | ||
| "block_quote": { | ||
| "indent": 0, | ||
| "color": "3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd keep 3 for the headings.
| }, | ||
| "heading": { | ||
| "block_suffix": "\n", | ||
| "color": "4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As said earlier, with my theme, 3 looks better. I found that setting 3 to a bright color looks better in some tools (htop, eza for instance), and in turns this make it more suitable to headings in my opinion. Very subjective though :-)
| "h1": { | ||
| "prefix": " ", | ||
| "suffix": " ", | ||
| "color": "7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
color could be 0, as we invert the colors compared to other headings.
| }, | ||
| "strong": { | ||
| "bold": true, | ||
| "color": "3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For emph and strong, I'd put 4.
| "underline": true | ||
| }, | ||
| "link_text": { | ||
| "color": "5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preference to have the same color as link_text, it makes it easier to understand they are the same units.
| "underline": true | ||
| }, | ||
| "image_text": { | ||
| "color": "5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, with a different color (image and image_text both 5?)
| "color": "7", | ||
| "prefix": " ", | ||
| "suffix": " ", | ||
| "background_color": "#44475a" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Colorful theme loosely based on the Dracula theme for 8-16 color terminals