Skip to content

Conversation

@ceuk
Copy link

@ceuk ceuk commented Dec 30, 2021

Colorful theme loosely based on the Dracula theme for 8-16 color terminals

Colorful theme loosely based on the Dracula theme for 8-16 color terminals
@aymanbagabas
Copy link
Member

We need to generate and include this style as a Go code.

Copy link

@autra autra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi \o I was precisely looking for that, thanks!

I made some comments with some improvements I believe. As this hasn't been touched for a while, I can also take over if that's ok for you @ceuk

},
"block_quote": {
"indent": 0,
"color": "3",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep 3 for the headings.

},
"heading": {
"block_suffix": "\n",
"color": "4",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said earlier, with my theme, 3 looks better. I found that setting 3 to a bright color looks better in some tools (htop, eza for instance), and in turns this make it more suitable to headings in my opinion. Very subjective though :-)

"h1": {
"prefix": " ",
"suffix": " ",
"color": "7",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

color could be 0, as we invert the colors compared to other headings.

},
"strong": {
"bold": true,
"color": "3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For emph and strong, I'd put 4.

"underline": true
},
"link_text": {
"color": "5",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preference to have the same color as link_text, it makes it easier to understand they are the same units.

"underline": true
},
"image_text": {
"color": "5",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, with a different color (image and image_text both 5?)

"color": "7",
"prefix": " ",
"suffix": " ",
"background_color": "#44475a"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a light background, this is way too dark:
image

I propose 254.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants