Skip to content

fix(tea): do not force color profile if session is not a PTY #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aymanbagabas merged 2 commits into from
Mar 25, 2025
Merged

fix(tea): do not force color profile if session is not a PTY #443

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7aac78
fix(tea): do not force color profile if session is not a PTY
aymanbagabas Mar 25, 2025
90effe0
Update bubbletea/tea.go
aymanbagabas Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion bubbletea/tea.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package bubbletea

import (
"context"
"fmt"
"strings"

tea "github.com/charmbracelet/bubbletea"
Expand Down Expand Up @@ -115,9 +116,18 @@ func MakeRenderer(sess ssh.Session) *lipgloss.Renderer {
if !ok {
cp = termenv.Ascii
}

r := newRenderer(sess)

// We only force the color profile if the requested session is a PTY.
_, _, ok = sess.Pty()
if !ok {
return r
}

if r.ColorProfile() > cp {
wish.Printf(sess, "Warning: Client's terminal is %q, forcing %q\r\n", profileNames[r.ColorProfile()], profileNames[cp])
_, _ = fmt.Fprintf(sess.Stderr(), "Warning: Client's terminal is %q, forcing %q\r\n",
profileNames[r.ColorProfile()], profileNames[cp])
r.SetColorProfile(cp)
}
return r
Expand Down
Loading